feat(plugindefinitions): enable OCI chart replication for ClusterPluginDefinition#1956
Merged
mikolajkucinski merged 6 commits intoMay 7, 2026
Merged
Conversation
mikolajkucinski
changed the title
mikolajkucinski
force-pushed
the
feat/cluster-plugindefinition-chart-replication
branch
2 times, most recently
from
f793836 to
c0357f7
Compare
mikolajkucinski
force-pushed
the
feat/cluster-plugindefinition-chart-replication
branch
from
c0357f7 to
3f6d325
Compare
mikolajkucinski
force-pushed
the
feat/cluster-plugindefinition-chart-replication
branch
from
3f6d325 to
41ebcd0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Wires the existing OCI mirroring feature flag into the ClusterPluginDefinition controller so that it can proactively warm a registry mirror (pull-through) for OCI Helm charts using Organization-provided mirror configuration (loaded from the greenhouse org/namespace).
Changes:
- Add
OCIMirroringEnabledplumbing toClusterPluginDefinitionReconcilerand invokeensureChartReplication()during reconciliation. - Inject the feature flag into the ClusterPluginDefinition controller startup path.
- Add a dedicated E2E suite covering successful and failing OCI chart replication for
ClusterPluginDefinition.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/controller/plugindefinition/cluster_plugindefinition_controller.go | Enables OCI chart replication flow for ClusterPluginDefinitions and adds required RBAC markers. |
| cmd/greenhouse/controllers.go | Starts the ClusterPluginDefinition controller with the OCI mirroring feature flag value. |
| e2e/clusterplugindefinition/testdata/organization.yaml | Adds Organization test fixture used by the new ClusterPluginDefinition E2E suite. |
| e2e/clusterplugindefinition/scenarios/cluster_pd_chart_replication.go | Adds E2E scenarios validating replication success, idempotency, and failure behavior. |
| e2e/clusterplugindefinition/e2e_test.go | Adds a new ClusterPluginDefinition-focused E2E test suite and environment setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikolajkucinski
force-pushed
the
feat/cluster-plugindefinition-chart-replication
branch
3 times, most recently
from
80ed308 to
c207440
Compare
abhijith-darshan
previously approved these changes
May 7, 2026
Contributor
abhijith-darshan
left a comment
abhijith-darshan
left a comment
There was a problem hiding this comment.
@mikolajkucinski - could you please increase the schedule for nightly E2E -
To every 2hours
…inDefinition Wire the existing OCIMirroringEnabled feature flag into the ClusterPluginDefinition reconciler and run ensureChartReplication. Mirror config is loaded from the greenhouse namespace. On-behalf-of: @SAP <mikolaj.kucinski@sap.com> Signed-off-by: Mikolaj Kucinski <osidu12@gmail.com>
On-behalf-of: @SAP <mikolaj.kucinski@sap.com> Signed-off-by: Mikolaj Kucinski <osidu12@gmail.com>
… scenarios On-behalf-of: @SAP <mikolaj.kucinski@sap.com> Signed-off-by: Mikolaj Kucinski <osidu12@gmail.com>
On-behalf-of: @SAP <mikolaj.kucinski@sap.com> Signed-off-by: Mikolaj Kucinski <osidu12@gmail.com>
On-behalf-of: @SAP <mikolaj.kucinski@sap.com> Signed-off-by: Mikolaj Kucinski <osidu12@gmail.com>
On-behalf-of: @SAP <mikolaj.kucinski@sap.com> Signed-off-by: Mikolaj Kucinski <osidu12@gmail.com>
mikolajkucinski
force-pushed
the
feat/cluster-plugindefinition-chart-replication
branch
from
c207440 to
3b39b0a
Compare
abhijith-darshan
approved these changes
May 7, 2026
mikolajkucinski
deleted the
feat/cluster-plugindefinition-chart-replication
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wire the existing OCIMirroringEnabled feature flag into the ClusterPluginDefinition reconciler and run ensureChartReplication. Mirror config is loaded from the greenhouse namespace.
Note: org name is hardcoded to greenhouse (via
flux.HelmRepositoryDefaultNamespace).What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist